#34. Kevin on 11 February 2009

@ Marc Palau: very well!

#33. Marc Palau on 06 February 2009

Ok Kevin, I will take a look with diferent timezones and I will fix it :)

thanks for your reply

#32. Kevin on 25 January 2009

@ Marc Palau: Maybe it's because we're in different timezones, but your function fails the second & 3rd test. So, sorry but I cannot replace the current implementation just yet.

And:

no = parseInt(argv[i]*1);

already multiplies by one, btw.

#31. Marc Palau on 17 January 2009

Two comments on one:

I'm not agree with tath mod. man, you are not filtering the arguments.
Definetively this is all wrong (sorry man)

I have rewrited the function, please take a test and tell me if I'm OK:

function mktime() {
  //agree here
    var d = new Date(), argv = arguments; 
  var cH=argv[0]!=undefined?argv[0]*1:d.getHours(),//hours
    ci=argv[1]!=undefined?argv[1]*1:d.getMinutes(),//minutes
    cs=argv[2]!=undefined?argv[2]*1:d.getSeconds(),//second
    cn=argv[3]!=undefined?(argv[3]*1)-1:d.getMonth(),//month
    cj=argv[4]!=undefined?argv[4]*1:d.getDate(),//day
    cY=argv[5]!=undefined?argv[5]*1:d.getYear()+1900;//year
  
  d.setHours(cH,ci,cs); d.setDate(cj); d.setMonth(cn); d.setYear(cY);
  
    return Math.floor(d.getTime()/1000);
}

To test I have used this code:

function test(){
  document.body.appendChild(div=document.createElement("div"));
  var w=function(v){
    div.innerHTML+=v+"<br>";
  }
 
  w("xx:xx:xx xx/xx/xxxx: "+mktime());
  w("10:xx:xx xx/xx/xxxx: "+mktime(10));
  w("10:10:xx xx/xx/xxxx: "+mktime(10,10,10));
  w("10:10:10 10/xx/xxxx: "+mktime(10,10,10,10));
  w("10:10:00 10/10/xxxx: "+mktime(10,10,10,10,10));
  w("10:10:10 10/10/2000: "+mktime(10,10,10,10,10,2000));
  w("00:00:00 05/03/2008: "+mktime(0, 0, 0, '05', '03', '2008')+" [<?=mktime(0, 0, 0, '05', '03', '2008')?>]");
  w("00:00:00 05/04/2008: "+mktime(0, 0, 0, '05', '04', '2008')+" [<?=mktime(0, 0, 0, '05', '04', '2008')?>]");
  w("00:00:00 05/05/2008: "+mktime(0, 0, 0, '05', '05', '2008')+" [<?=mktime(0, 0, 0, '05', '05', '2008')?>]");
  w("00:00:00 05/06/2008: "+mktime(0, 0, 0, '05', '06', '2008')+" [<?=mktime(0, 0, 0, '05', '06', '2008')?>]");
  w("00:00:00 05/07/2008: "+mktime(0, 0, 0, '05', '07', '2008')+" [<?=mktime(0, 0, 0, '05', '07', '2008')?>]");
  w("00:00:00 05/08/2008: "+mktime(0, 0, 0, '05', '08', '2008')+" [<?=mktime(0, 0, 0, '05', '08', '2008')?>]");
  w("00:00:00 05/09/2008: "+mktime(0, 0, 0, '05', '09', '2008')+" [<?=mktime(0, 0, 0, '05', '09', '2008')?>]");
  w("00:00:00 05/10/2008: "+mktime(0, 0, 0, '05', '10', '2008')+" [<?=mktime(0, 0, 0, '05', '10', '2008')?>]");
  w("00:00:00 05/11/2008: "+mktime(0, 0, 0, '05', '11', '2008')+" [<?=mktime(0, 0, 0, '05', '11', '2008')?>]");
}

And a free tip:
parseInt('09') it's an octet, 9 don't exist, return false or 0; parseInt('08') will fail too
parseInt('05') return 5
parseInt('010') return 8
parseInt('011') return 9
var n='09'*1; work fine ;) //parseInt it's not necesary


Please, make the textarea bigger ;)

if you need something more, please send me an e-mail :) (I visit usually your project, but not every day)
good luck!
Marc
http://www.nbsp.es

#30. Kevin on 16 January 2009

@ Marc Palau: We still need that line for the other examples to work, but I think we got it right now. Agree? Thanks for helping us out Marc!

#29. Marc Palau on 16 January 2009

Kevin, the returned value by mktime on php without arguments (or with less arguments) is based on the current date, not [0,0,0,1,1,1972].

To solve, just delete this line:

d.setHours(0,0,0); d.setDate(1); d.setMonth(1); d.setYear(1972);

Thanks!!
Marc

#28. Kevin on 18 July 2008

@ jakes: Thanks for your input. I've updated the function

#27. jakes on 01 July 2008

when iterating through a loop with negative values for month, on the transition to positive (zero month) php delivers expected values but js doesnt, ie:

alert(mktime(0,0,0,0,1,2008) + " - " + date('d M Y', mktime(0,0,0,0,1,2008)));

echo mktime(0, 0, 0, 0, 1, 2008)." - ".date("d M Y", mktime(0, 0, 0, 0, 1, 2008));

js: 1201788000 - 01 Feb 2008
php: 1196427600 - 01 Dec 2007

#26. Kevin on 21 May 2008

@ Yanno: I have found the bug. It lays in using '09'. When using a number 9, the function worked normally. So I investigated further and it turns out that

parseInt('09') // returns 0 instead of 9

Multiplying by 1 seems to work:

parseInt('09'*1) // returns 9 as it 'should'

Thank you for all the info.

#25. Yann on 21 May 2008

Well, this is my script :

function dateFr2timestamp(dateFr) {
  var a_date = explode('/', dateFr); // array with {0:day; 1:month; 2:year)
  return mktime(0,0,0,a_date[1],a_date[0],a_date[2]);
}

dateFr is any date to french format (dd/mm/yyyy) --> '08/05/2008', '01/01/2008', '31/12/2008', ...

With dates '08/05/2008' and '09/05/2008', there are problems : wrong timestamp

#24. Yannoo on 21 May 2008

@Kevin
I've test different date. Look results :

alert(mktime(0, 0, 0, '05', '03', '2008')); // 1209765600
alert(mktime(0, 0, 0, '05', '04', '2008')); // 1209852000
alert(mktime(0, 0, 0, '05', '05', '2008')); // 1209938400
alert(mktime(0, 0, 0, '05', '06', '2008')); // 1210024800
alert(mktime(0, 0, 0, '05', '07', '2008')); // 1210111200
alert(mktime(0, 0, 0, '05', '08', '2008')); // 1209592800 (it should be 1210197600)
alert(mktime(0, 0, 0, '05', '09', '2008')); // 1209592800 (it should be 1210284000)
alert(mktime(0, 0, 0, '05', '10', '2008')); // 1210370400
alert(mktime(0, 0, 0, '05', '11', '2008')); // 1210465800

My timezone is Paris (GMT+1)

#23. @Kevin on 21 May 2008

I've test different date. Look results :

alert(mktime(0, 0, 0, 5, 03, 2008)); // 1209765600
alert(mktime(0, 0, 0, 5, 04, 2008)); // 1209852000
alert(mktime(0, 0, 0, 5, 05, 2008)); // 1209938400
alert(mktime(0, 0, 0, 5, 06, 2008)); // 1210024800
alert(mktime(0, 0, 0, 5, 07, 2008)); // 1210111200
alert(mktime(0, 0, 0, 5, 08, 2008)); // 1209592800
alert(mktime(0, 0, 0, 5, 09, 2008)); // 1209592800
alert(mktime(0, 0, 0, 5, 10, 2008)); // 1210370400
alert(mktime(0, 0, 0, 5, 11, 2008)); // 1210465800

#22. Kevin on 21 May 2008

@ Yannoo: What output are you getting? What should it be? Could this be related to the different timezones?

#21. Yannoo on 21 May 2008

There are a probleme with :

mktime(0, 0, 0, 5, 8, 2008);
mktime(0, 0, 0, 5, 9, 2008);

The timestamp is wrong !

#20. Kevin on 22 April 2008

@ Philip Peterson: If it's even possible to set the timezone for an entire page... I think you can only do this to a date object.

So maybe the right approach is to include a

+(date.getTimeZoneOffset() * 60 * 60);

In the test to neutralize the end user's timezone?

#19. Kevin on 22 April 2008

@ Philip Peterson: Hi Philip. Running the tests in a predefined timezone seems to be a good solution. We should opt for UTC I think. Then adjust the 'result' comment to match the UTC outcome of mktime. Much better indeed!

#18. Philip Peterson on 21 April 2008

Hmm, yeah, I figured that might be it, but does PHP do that? If not it might be a good idea to set the timezone to UTC/GMT/Something as a standard, or maybe including a config file to choose whether to leave it up to the user's computer or to set a standard?

#17. Kevin on 20 April 2008

@ Philip Peterson: Yeah that's related to the different timezones that we are in.

#16. Philip Peterson on 20 April 2008

Just so you know... this is six hours off in firefox, I think? :-/ In the php_tester example, at least... I'm not sure what's doing it, though...

#15. Kevin on 19 April 2008

@ FGFEmperor: Thanks a lot!

#14. FGFEmperor on 18 April 2008

OK, now setting a month to something greater than 11 would not increase the year...
My correction (also for hours, minutes and seconds...

var no, ma = 0, mb = 0, i = 0, d = new Date(), argv = arguments, argc = argv.length;
    d.setHours(0,0,0); d.setDate(1); d.setMonth(1); d.setYear(1972);
 
    var dateManip = {
        0: function(tt){ return d.setHours(tt); },
        1: function(tt){ return d.setMinutes(tt); },
        2: function(tt){ set = d.setSeconds(tt); mb = d.getDate() - 1; return set; },
        3: function(tt){ set = d.setMonth(parseInt(tt)-1); ma = d.getFullYear() - 1972; return set; },
        4: function(tt){ return d.setDate(tt+mb); },
        5: function(tt){ return d.setYear(tt+ma); }
    };

Basically I added 'ma' and 'mb' to the vars, and summed that on Years and Days... =)

#13. Kevin on 02 April 2008

@ FGFEmperor: Good work man, thanks a lot, I'll update the function!

#12. FGFEmperor on 31 March 2008

OK, another update:
change
d.setYear(1970);
to
d.setYear(1972);
... [more] Why? Because this way Leap Years are gonna work.

#11. FGFEmperor on 31 March 2008

Got It!
Add

d.setHours(0,0,0); d.setDate(1); d.setMonth(1); d.setYear(1970);

after

var no, i = 0, d = new Date(), argv = arguments, argc = argv.length;

The catch here is that d = New Date(); sets d to the current date. What was happening is that today is the 31th, and I the function was setting the month to February, but the day was still the 31th, then it would set the month to March (since February has only 28/29 days). ;-)

#10. FGFEmperor on 31 March 2008

I have no idea why, but this:
alert('PHP: <?= mktime(0,0,0,4,5,2009); ?>\nJS: '+mktime(0,0,0,4,5,2009));
returns this:
PHP: 1238900400
JS: 1241550694
... [more] Any idea why? That way, I should get 4/5/2009 for both, but I'm getting 5/5/2009 on the JS version...

#9. Kevin on 23 March 2008

@ gabriel paderni: The example won't reproduce:
http://kevin.vanzonneveld.net/test.php

But I've added the parseInt function. Does that solve the bug? Thanks gabriel!

#8. gabriel paderni on 22 March 2008

If i'm not mistaken there's a bug when using strings as parameters:

here is the test I've made:

<script type="text/javascript">
function mktimetest(t_php,t_js){
  document.write(t_php+'
'+t_js);
  if(t_php!=t_js)document.write(' &lt;- Error');
  document.write('
 
');
}
mktimetest(<?php echo mktime('01','30','10','06','21','2008')?>,mktime('01','30','10','06','21','2008'));
mktimetest(<?php echo mktime('01','30','10','07','21','2008')?>,mktime('01','30','10','07','21','2008'));
mktimetest(<?php echo mktime('01','30','10','08','21','2008')?>,mktime('01','30','10','08','21','2008'));
mktimetest(<?php echo mktime('01','30','10','09','21','2008')?>,mktime('01','30','10','09','21','2008'));
mktimetest(<?php echo mktime('01','30','10','10','21','2008')?>,mktime('01','30','10','10','21','2008'));
mktimetest(<?php echo mktime('01','30','10','11','21','2008')?>,mktime('01','30','10','11','21','2008'));
</script>

Strangely in the test this shows up only for August and September.

The solution may be to remove the leading zero when the parameter is a string.

(Tested with: Firefox and Internet explorer, same result.)

#7. Kevin on 02 March 2008

@ Michael White: Tried to reproduce the behavior, but wasn't able to:
http://kevin.vanzonneveld.net/test.php

#6. Michael White on 02 March 2008

The example appears to be incorrect for this function. I checked in a PHP script to verify this and to get the correct value.

The new example:

// *     example 1: mktime( 14, 10, 2, 2, 1, 2008 );
    // *     returns 1: 1201893002

#5. Kevin on 21 February 2008

@ baris ozdil: Thank your for your contribution, I've updated php.js and included you in the credits!

#4. baris ozdil on 21 February 2008

Hi Kevin,
Thanks a lot for this nice library.
Just a small correction in mktime. In javascript the setMonth the month values are 0 based indexed. I think it should be something like this:

var dateManip = {
        0: function(tt){ return d.setHours(tt); },
        1: function(tt){ return d.setMinutes(tt); },
        2: function(tt){ return d.setSeconds(tt); },
        3: function(tt){ return d.setMonth(parseInt(tt)-1); },
        4: function(tt){ return d.setDate(tt); },
        5: function(tt){ return d.setYear(tt); }
    };

#3. Kevin on 03 February 2008

@ _argos: One thing: array_rand produces javascript errors when you feed it an object instead of an array. maybe we should implement some sort of sanity checking there.

Other than that: Nice work again man, you've earned yourself 2 gold medals :)

#2. _argos on 03 February 2008

Kevin, a litle fix in array_product

function array_product ( input ) {
var Index = 0, Product = 1;

... [more] if ( input instanceof Array ) {
while ( Index < input.length ) {
Product *= ( !isNaN ( input [ Index ] ) ? input [ Index ] : 0 );
Index++;
}
} else {
Product = null;
}

return Product;
}

#1. _argos on 03 February 2008

Hi Kevin, I'm attaching 3 functions more for the PHP.js project.

function array_product ( input ) {
  var Index = 0, Product = 1;
  
  if ( input instanceof Array ) {
    while ( Index < input.length  ) {
      Product *= ( !isNaN ( input [ Index ] ) ? input [ Index ] : 0 );
      Index++;
    }
  } else {
    product = null;
  }
      
  return product;
}
 
function array_rand ( input, num_req ) {
  var Indexes = [];
  var Ticks = num_req || 1;
  var Check = {
    Duplicate  : function ( input, value ) {
      var Exist = false, Index = 0;
      while ( Index < input.length ) {
        if ( input [ Index ] === value ) {
          Exist = true;
          break;
        }
        Index++;
      }      
      return Exist;
    }
  };
  
  if ( input instanceof Array && Ticks <= input.length ) {
    while ( true ) {
      var Rand = Math.floor ( ( Math.random ( ) * input.length ) );
      if ( Indexes.length === Ticks ) { break; }
      if ( !Check.Duplicate ( Indexes, Rand ) ) { Indexes.push ( Rand ); }
    }
  } else {
    Indexes = null;
  }
  
  return ( ( Ticks == 1 ) ? Indexes.join ( ) : Indexes );
}
 
function compact ( var_names ) {
  var Index = 0, Matrix = {};
  var Process = function ( value ) {
    for ( var i = 0; i < value.length; i++ ) {
      var key_value = value [ i ];      
      if ( key_value instanceof Array ) {
        Process ( key_value );
      } else {
        if ( typeof window [ key_value ] !== 'undefined' ) {
          Matrix [ key_value ] = window [ key_value ];
        }
      }
    }
    return true;
  };
  
  Process ( arguments );
 
  return Matrix;
}