#8. Kevin on 16 March 2009

@ mk.keck: I will review your comment soon over at http://phpjs.org . Please bear with me, and use that new site for comments on PHP.JS from now on.

Thanks a lot!!

#7. mkl.keck on 06 March 2009

Imprived function intval:

function intval() {
    var a = arguments;
    var v = a[0];
    var t = typeof(a[0])
    var b = ( (typeof(a[1]) !== 'undefined' && !isNaN(a[1])) ? parseInt(a[1]) : 10 );
    switch (t.substring(0, 1).toLowerCase()) {
        case 'b':
            return ( (v === true) ? 1 : 0 );
        case 's':
            var r = parseInt(v * 1);
            return ( (!isNaN(v) && isFinite(v)) ? r.toString(b) : 0 );
        case 'n':
            return ( isFinite(v) ? Math.floor(v) : 0 );
        default:
            return 0;
    }
}

#6. Kevin on 31 May 2008

@ Alex: Thank you Alex. Added!

#5. Alex on 30 May 2008

function isInt(x)
{
var y=parseInt(x);
if (isNaN(y)) return false;
return x==y && x.toString()==y.toString();
... [more] }

taken from http://community.livejournal.com/nullzone/1223.html

#4. Kevin on 14 May 2008

@ stenci: Thanks a lot for your improvements stensi!

#3. stensi on 14 May 2008

Sorry for double post. I didn't give the correct code syntax highlighting first time round.

I noticed I the example I gave had an incorrect call:

alert( intval_modified(num) );

Should of course be:

alert( intval(num) );

#2. stensi on 14 May 2008

Just stumbled across your PHP.js library, awesome work Kevin :)

I think your intval could be improved a little to handle JavaScripts "Infinity" value.

for example, using current PHP.js intval:

function intval( mixed_var, base ) {
    // http://kevin.vanzonneveld.net
    // +   original by: Kevin van Zonneveld (http://kevin.vanzonneveld.net)
    // *     example 1: intval('Kevin van Zonneveld');
    // *     returns 1: 0
    // *     example 2: intval(4.2);
    // *     returns 2: 4
    // *     example 3: intval(42, 8);
    // *     returns 3: 42
 
    var tmp;
 
    if( typeof( mixed_var ) == 'string' ){
        tmp = parseInt(mixed_var);
        if(isNaN(tmp)){
            return 0;
        } else{
            return tmp.toString(base || 10);
        }
    } else if( typeof( mixed_var ) == 'number' ){
        return Math.floor(mixed_var);
    } else{
        return 0;
    }
}
 
// set num to: Infinity
var num = 1 / 0;
 
// using current PHP.js intval returns: Infinity
alert( intval(num) );
 
// Output: Infinity

Using modified intval to handle Infinity:

function intval( mixed_var, base ) {
    // http://kevin.vanzonneveld.net
    // +   original by: Kevin van Zonneveld (http://kevin.vanzonneveld.net)
    // *     example 1: intval('Kevin van Zonneveld');
    // *     returns 1: 0
    // *     example 2: intval(4.2);
    // *     returns 2: 4
    // *     example 3: intval(42, 8);
    // *     returns 3: 42
 
    var tmp;
 
    if( typeof( mixed_var ) == 'string' ){
        tmp = parseInt(mixed_var);
        if(isNaN(tmp) || !isFinite(tmp)){
            return 0;
        } else{
            return tmp.toString(base || 10);
        }
    } else if( typeof( mixed_var ) == 'number' && isFinite(mixed_var) ){
        return Math.floor(mixed_var);
    } else{
        return 0;
    }
}
 
// set num to: Infinity
var num = 1 / 0;
 
// using intval_modified to handle Infinity returns: 0
alert( intval_modified(num) );
 
// Output: 0

Basically, the changes are:

if(isNaN(tmp)){

to:

if(isNaN(tmp) || !isFinite(tmp)){

and...

} else if( typeof( mixed_var ) == 'number' ){

to:

} else if( typeof( mixed_var ) == 'number' && isFinite(mixed_var) ){

#1. stensi on 14 May 2008

Just stumbled across your PHP.js library, awesome work Kevin :)

I think your intval could be improved a little to handle JavaScripts "Infinity" value better.

For example, using current PHP.js intval:
[code]
function intval( mixed_var, base ) {
// http://kevin.vanzonneveld.net
// + original by: Kevin van Zonneveld (http://kevin.vanzonneveld.net)
// * example 1: intval('Kevin van Zonneveld');
// * returns 1: 0
// * example 2: intval(4.2);
// * returns 2: 4
// * example 3: intval(42, 8);
// * returns 3: 42

var tmp;

if( typeof( mixed_var ) == 'string' ){
tmp = parseInt(mixed_var);
if(isNaN(tmp)){
return 0;
} else{
return tmp.toString(base || 10);
}
} else if( typeof( mixed_var ) == 'number' ){
return Math.floor(mixed_var);
} else{
return 0;
}
}

// set num to: Infinity
var num = 1 / 0;

// using current PHP.js intval returns: Infinity
alert( intval(num) );

// Output: Infinity
[/code]


Using modified intval to handle Infinity:
[code]
function intval( mixed_var, base ) {
// http://kevin.vanzonneveld.net
// + original by: Kevin van Zonneveld (http://kevin.vanzonneveld.net)
// * example 1: intval('Kevin van Zonneveld');
// * returns 1: 0
// * example 2: intval(4.2);
// * returns 2: 4
// * example 3: intval(42, 8);
// * returns 3: 42

var tmp;

if( typeof( mixed_var ) == 'string' ){
tmp = parseInt(mixed_var);
if(isNaN(tmp) || !isFinite(tmp)){
return 0;
} else{
return tmp.toString(base || 10);
}
} else if( typeof( mixed_var ) == 'number' && isFinite(mixed_var) ){
return Math.floor(mixed_var);
} else{
return 0;
}
}

// set num to: Infinity
var num = 1 / 0;

// using intval_modified to handle Infinity returns: 0
alert( intval_modified(num) );

// Output: 0
[/code]

Basically, the changes are:
[code]if(isNaN(tmp)){[/code]
to:
[code]if(isNaN(tmp) || !isFinite(tmp)){[/code]

and...

[code]} else if( typeof( mixed_var ) == 'number' ){[/code]
to:
[code]} else if( typeof( mixed_var ) == 'number' && isFinite(mixed_var) ){[/code]